Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 Starting Point #251

Merged
merged 84 commits into from
Jan 3, 2024
Merged

Phase 2 Starting Point #251

merged 84 commits into from
Jan 3, 2024

Conversation

dzalkind
Copy link
Collaborator

@dzalkind dzalkind commented Nov 14, 2023

Purpose

The goal of this branch is to update the subtrees (OpenFAST, ROSCO, WISDEM, RAFT) and fix all the issues before making new changes in Phase 2. We can start on this branch for any new Phase 2 developments.

There are a few glue code and usability updates I added from working on the IEA-22 RWT. A summary of the changes are as follows.

Major changes:

Minor changes:

  • Updates to the CI for using mamba/miniconda, which builds the environments faster
  • Path inputs given to modeling options are relative to that (modeling options) file
  • Example 04 is now "under construction" until we resolve the issue with multiple water variable ballast containers
  • FAST reader/writer updates and bug fixes
  • GridWidth/Height will overwrite defaults if provided in DLC driver
  • Re-allocate ballast into individual chambers for RAFT
  • OpenFAST outputs will be placed with analysis outputs, by default
  • Some optimization targets can be derived from either floatingse, RAFT, or OpenFAST

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

dzalkind and others added 30 commits April 13, 2023 15:24
git-subtree-dir: WISDEM
git-subtree-split: 0e9caf93103c2b3762d7b9bfbd4109ccdbd53b21
@yonghoonlee
Copy link
Contributor

Hi Dan,
When do you anticipate to merge this PR into the develop branch?
Thank you.
Yong Hoon

weis/frequency/raft_wrapper.py Show resolved Hide resolved
weis/glue_code/gc_PoseOptimization.py Show resolved Hide resolved
weis/glue_code/glue_code.py Show resolved Hide resolved
@dzalkind dzalkind linked an issue Dec 22, 2023 that may be closed by this pull request
@dzalkind dzalkind linked an issue Dec 22, 2023 that may be closed by this pull request
@dzalkind dzalkind linked an issue Dec 22, 2023 that may be closed by this pull request
@dzalkind dzalkind merged commit bdd99c2 into develop Jan 3, 2024
15 checks passed
@gbarter gbarter deleted the phase2 branch January 24, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants