Add custom element default focusability proposal #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rniwa
approved these changes
Sep 4, 2019
|
Are you proposing this as an agenda item for #826? |
Yeah I think it'd be nice to talk about this in the TPAC session! |
domenic
approved these changes
Sep 4, 2019
| The proposed API above uses a CSS selectors to represent the built-in elements, but we’ve also considered some variants: | ||
|
|
||
| - Using “tagname + one attribute name + attribute’s value” combination, | ||
| e.g. `elementInternals.matchFocusBehaviorOf = {"input", "type," "button"}` |
There was a problem hiding this comment.
This isn't valid JS syntax. Maybe matchFocusBehaviorOf("input", "type", "button") or three separate attributes or something like that.
Could you add a comment in the issue? |
Co-Authored-By: Domenic Denicola <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a summary of discussions in #762.
The proposed API uses CSS-selector like syntax, but other shapes for the API are also listed in the "alternatives considered" part.
cc @domenic @tkent-google @rniwa @alice @annevk from the thread