Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Explicitly set service worker mode to none #1351

Merged
merged 1 commit into from
Dec 2, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -2591,18 +2591,17 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url| and an [=environment setti
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
:: "`no-referrer`"
:: "`no-referrer`"
: [=request/credentials mode=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"
:: "`error`"
: [=request/service-workers mode=]
:: "`none`"
: [=request/policy container=]
:: A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
[=environment settings object/policy container=]'s [=policy container/IP address space=]

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.

Issue: Stop using "`no-cors`" mode where possible
(<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
1. Let |moduleObject| be null.
Expand Down Expand Up @@ -2638,18 +2637,17 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, an [=origin=] |script
: [=request/mode=]
:: "`cors`"
: [=request/referrer=]
:: "`no-referrer`"
:: "`no-referrer`"
: [=request/credentials mode=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"
:: "`error`"
: [=request/service-workers mode=]
:: "`none`"
: [=request/policy container=]
:: A new [=policy container=] whose [=policy container/IP address space=] is |policyContainer|'s
[=policy container/IP address space=]

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.

1. Let |signals| be null.
1. Let |dataVersion| be null.
1. Let |formatVersion| be null.
Expand Down Expand Up @@ -2763,18 +2761,17 @@ To <dfn>send report</dfn> given a [=URL=] |url|, and an [=environment settings o
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
:: "`no-referrer`"
:: "`no-referrer`"
: [=request/credentials mode=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"
:: "`error`"
: [=request/service-workers mode=]
:: "`none`"
: [=request/policy container=]
:: A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
[=environment settings object/policy container=]'s [=policy container/IP address space=]

Issue: One of the side-effects of a `null` client for this subresource request is it neuters
all service worker interceptions, despite not having to set the service workers mode.

Issue: Stop using "`no-cors`" mode where possible
(<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true.
Expand Down Expand Up @@ -4068,18 +4065,17 @@ Initial implementation of this specification defines
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
:: "`no-referrer`"
:: "`no-referrer`"
: [=request/credentials mode=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"
:: "`error`"
: [=request/service-workers mode=]
:: "`none`"
: [=request/policy container=]
:: A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
[=environment settings object/policy container=]'s [=policy container/IP address space=]

Issue: One of the side-effects of a `null` client for this subresource request is it neuters
all service worker interceptions, despite not having to set the service workers mode.

Issue: Stop using "`no-cors`" mode where possible
(<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true.
Expand Down Expand Up @@ -6528,18 +6524,17 @@ navigating to another page. Some implementations, such as Chromium, have chosen
: [=request/mode=]
:: "`no-cors`"
: [=request/referrer=]
:: "`no-referrer`"
:: "`no-referrer`"
: [=request/credentials mode=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"
:: "`error`"
: [=request/service-workers mode=]
:: "`none`"
: [=request/policy container=]
:: A new [=policy container=] whose [=policy container/IP address space=] is |policyContainer|'s
[=policy container/IP address space=]

Issue: One of the side-effects of a `null` client for this subresource request is it neuters
all service worker interceptions, despite not having to set the service workers mode.

Issue: Stop using "`no-cors`" mode where possible
(<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).
1. Let |update| be null.
Expand Down Expand Up @@ -7080,11 +7075,11 @@ To <dfn>check interest group permissions</dfn> given an [=origin=] |ownerOrigin|
: [=request/mode=]
:: "`cors`"
: [=request/referrer=]
:: "`no-referrer`"
:: "`no-referrer`"
: [=request/credentials mode=]
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"
:: "`error`"
: [=request/service-workers mode=]
:: `none`
: [=request/policy container=]
Expand Down Expand Up @@ -8239,13 +8234,12 @@ a [=script fetcher=] |fetcher|:
:: "`omit`"
: [=request/redirect mode=]
:: "`error`"
: [=request/service-workers mode=]
:: "`none`"
: [=request/policy container=]
:: A new [=policy container=] whose [=policy container/IP address space=] is |settings|'s
[=environment settings object/policy container=]'s [=policy container/IP address space=]

Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
service worker interceptions, despite not having to set the service workers mode.

Issue: Stop using "`no-cors`" mode where possible
(<a href="https://github.com/WICG/turtledove/issues/667">WICG/turtledove#667</a>).

Expand Down