[Spec] Explicitly set service worker mode to none #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set requests' service worker mode to null, instead of using a note to explain the service working mode being null when client is set to null
|
@morlovich We probably want to set skip_service_worker to true explicitly as well? Our code currently behaves the same as it being set to true since the client is "null" although it uses the default value false, IIUC, is that right? |
domfarolino
approved these changes
Dec 2, 2024
It's probably a good idea to do it defensively, yes, but the reason it doesn't involve service workers is because it's talking to a layer where they haven't been hooked up, and not really calling fetch(), which doesn't really exist as such in Chrome outside the renderer. |
morlovich
approved these changes
Dec 2, 2024
github-actions bot
added a commit
that referenced
this pull request
Dec 2, 2024
SHA: 6a37e10 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set requests' service worker mode to null, instead of using a note to explain the service working mode being null when client is set to null.
It first came from this comment
Preview | Diff