Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send Sec-CH-Width when we're using a fallback sizes. #27

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Don't send Sec-CH-Width when we're using a fallback sizes. #27

merged 1 commit into from
Jun 15, 2023

Conversation

eeeps
Copy link
Collaborator

@eeeps eeeps commented Jun 2, 2023

Fixes #19

@eeeps eeeps requested a review from yoavweiss June 2, 2023 22:17
@jonarnes
Copy link

jonarnes commented Jun 9, 2023

LGTM

@eeeps
Copy link
Collaborator Author

eeeps commented Jun 15, 2023

@jonarnes Thanks! I'll go ahead and land this, and then:

  1. file a follow up issue to resolve the note about tracking was-a-fallback-sizes-used state
  2. keep bugging @yoavweiss for feedback and ask him to submit issues rather than PR comments
  3. submit a WPT PR with tests for this

@eeeps eeeps merged commit 7987b92 into WICG:main Jun 15, 2023
@eeeps eeeps deleted the dont-send-width-sometimes branch June 15, 2023 13:42
github-actions bot added a commit that referenced this pull request Jun 15, 2023
@eeeps @github-actions
Merge pull request #27 from eeeps/dont-send-width-sometimes
62e654b 
SHA: 7987b92
Reason: push, by eeeps

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@eeeps eeeps mentioned this pull request Jun 15, 2023
Open
@yoavweiss
Copy link
Collaborator

Did relevant WPT changes and/or implementation bugs filed for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss Awaiting requested review from yoavweiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Sec-CH-Width be sent when the sizes attribute is not present?
3 participants
@eeeps @jonarnes @yoavweiss