Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify some kind of fallback-sizes-value-was-used state tracking #30

Open
eeeps opened this issue Jun 15, 2023 · 1 comment · May be fixed by #33
Open

Specify some kind of fallback-sizes-value-was-used state tracking #30

eeeps opened this issue Jun 15, 2023 · 1 comment · May be fixed by #33
Assignees

Comments

@eeeps
Copy link
Collaborator

eeeps commented Jun 15, 2023

Follow up from #27...

Right now we state that Sec-CH-Width must not be sent if a fallback size was used, and point at the step in the "parse a sizes attribute" algorithm that establishes whether a fallback size was used or not, but don't specify how that state is tracked across time between when the "parse a sizes attribute" algorithm is run and when "append client hints to request" is run.

I think... we probably need to do that? Open to hearing that we don't of course. In which case I'll remove the note in the spec.

@yoavweiss
Copy link
Collaborator

Yeah, makes sense to properly pass that state between the two algorithms. (and apologies for my slowness)

@eeeps eeeps self-assigned this Jun 21, 2023
eeeps added a commit that referenced this issue Apr 19, 2024
@eeeps eeeps linked a pull request Apr 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants