Handle navigation and traversal cancelation more uniformly #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cancelation of queued-up traversals was ignored. Now it triggers the appropriate finalization algorithm.
The introduction of a "fired navigate event" boolean on the ongoing app history API navigation struct also ensures that we don't fire navigateerror on cases where we never fire the navigate event.
Also closes #141 while we're there.
Finally, this removes the microtask delay in "finalize with an aborted navigation error". This works poorly in practice, because if a navigation interrupts another navigation, you want the navigateerror for the old navigation to fire before the navigate for the new navigation.
Preview | Diff