Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early bail out spec for canRespond = false, cancelable = false seems wrong #141

Closed
domenic opened this issue Jul 30, 2021 · 0 comments · Fixed by #143
Closed

Early bail out spec for canRespond = false, cancelable = false seems wrong #141

domenic opened this issue Jul 30, 2021 · 0 comments · Fixed by #143
Assignees
@domenic

Comments

@domenic
Copy link
Collaborator

domenic commented Jul 30, 2021

https://wicg.github.io/app-history/#navigate-event-firing step 8 will bail out if canRespond is false and cancelable is false. As part of that bailout, it will clean up the ongoing navigation, and resolve the promise.

However, canRespond = false and cancelable = false only happens for cross-document browser UI navigations. In those cases, as with all cross-document navigations, our current plan is to leave the promise unsettled. That might change in #95, but for now the spec seems broken.
@domenic domenic self-assigned this Jul 30, 2021
domenic added a commit that referenced this issue Aug 4, 2021
@domenic
Handle navigation and traversal cancelation more uniformly
bb290e2 
Previously, cancelation of queued-up traversals was ignored. Now it triggers the appropriate finalization algorithm.

The introduction of a "fired navigate event" boolean on the ongoing app history API navigation struct also ensures that we don't fire navigateerror on cases where we never fire the navigate event.

Also closes #141 while we're there.
@domenic domenic mentioned this issue Aug 4, 2021
Merged
domenic added a commit that referenced this issue Aug 4, 2021
@domenic
Handle navigation and traversal cancelation more uniformly
1dc470a 
Previously, cancelation of queued-up traversals was ignored. Now it triggers the appropriate finalization algorithm.

The introduction of a "fired navigate event" boolean on the ongoing app history API navigation struct also ensures that we don't fire navigateerror on cases where we never fire the navigate event.

Also closes #141 while we're there.
domenic added a commit that referenced this issue Aug 6, 2021
@domenic
Handle navigation and traversal cancelation more uniformly
0e75539 
Previously, cancelation of queued-up traversals was ignored. Now it triggers the appropriate finalization algorithm.

The introduction of a "fired navigate event" boolean on the ongoing app history API navigation struct also ensures that we don't fire navigateerror on cases where we never fire the navigate event.

Also closes #141 while we're there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domenic domenic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle navigation and traversal cancelation more uniformly WICG/navigation-api
1 participant
@domenic