Add Permission Policy #132
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -272,6 +272,16 @@ <h3> | |
| The <dfn data-dfn-for="DigitalCredential">data</dfn> member is the | ||
| credential's response data. | ||
| </p> | ||
| <h3> | ||
| [[\DiscoverFromExternalSource]](origin, options, sameOriginWithAncestors) | ||
| internal method | ||
| </h3> | ||
| <ol> | ||
| <li>If |document| is not [=allowed to use=] the | ||
| <a>"digital-credentials-get"</a> permission, then [=exception/throw=] a | ||
| {{"NotAllowedError="}} {{DOMException}}. | ||
| </li> | ||
| </ol> | ||
| <h3> | ||
| [[\Store]](credential, sameOriginWithAncestors) internal method | ||
| </h3> | ||
|
|
@@ -309,6 +319,29 @@ <h3> | |
| <dfn class="export" data-dfn-for="DigitalCredential">[[\discovery]]</dfn> | ||
| whose value is "remote". | ||
| </p> | ||
| <section class="informative"> | ||
| <h3> | ||
| User consent | ||
| </h3> | ||
| <p> | ||
| The <cite>Digital Credential API</cite> is a [=powerful feature=] that | ||
| requires [=express permission=] from an end-user. This requirement is | ||
| normatively enforced when calling `navigator.identity.get()` via the | ||
| {{DigitalCredential\[[DiscoverFromExternalSource]](origin, options, | ||
| sameOriginWithAncestors)}} internal method. | ||
marcoscaceres marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| </p> | ||
| </section> | ||
| <section id="permissions-policy" data-cite="permissions-policy"> | ||
| <h2> | ||
| Permissions Policy integration | ||
| </h2> | ||
| <p> | ||
| This specification defines a [=policy-controlled feature=] identified | ||
| by the string <dfn class="permission">"digital-credentials-get"</dfn> | ||
|
There was a problem hiding this comment. FYI we also kicked off the registration in the permissions policy spec here: https://github.com/w3c/webappsec-permissions-policy/pull/549/files There was a problem hiding this comment. Great. I'll add WebKit there too. |
||
| [[permissions-policy]]. Its [=policy-controlled feature/default | ||
marcoscaceres marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| allowlist=] is [=allowlist/'self'=]. | ||
| </p> | ||
| </section> | ||
| <h2 id="protocol-registry"> | ||
| Registry of protocols for requesting digital credential | ||
| </h2> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebAuthn seems to say we can't do this here due to lack of access to the settings object. I haven't looked into the details though, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right! I need to add it to the Cred Man itself! That's what they do for WebAuthn. I'll do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RByers sent w3c/webappsec-credential-management#242