Use credential type registry for permissions + digital credentials #242
Conversation
| @@ -98,20 +98,15 @@ spec:css-syntax-3; | |||
| </pre> | |||
| <pre class="biblio"> | |||
| { | |||
| "FEDCM": { | |||
There was a problem hiding this comment.
Already in Specref... don't need this... or WEB-OTP
| @@ -965,8 +988,6 @@ spec:css-syntax-3; | |||
| 1. If |interface| does not support {{CredentialMediationRequirement/conditional}} | |||
| [=user mediation=], return [=a promise rejected with=] a "{{TypeError}}" {{DOMException}}. | |||
|
|
|||
| 1. Let |p| be [=a new promise=]. | |||
There was a problem hiding this comment.
Was defined before it was used! oops!
index.bs
Outdated
| <td>[[FEDCM]]</td> | ||
| <td><a href="https://www.w3.org/community/fed-id/">W3C</a></td> | ||
| </tr> | ||
| <tr> | ||
| <td>otp</td> | ||
| <td>otp</td> | ||
| <td>{{OTPCredential}}</td> | ||
| <td>otp-credentials</td> |
There was a problem hiding this comment.
looks like you're missing a <td>null</td> here.
index.bs
Outdated
| [=allowed to use=] the [=identity-credentials-get=] | ||
| [=policy-controlled feature=] return [=a promise rejected with=] a "{{NotAllowedError}}" | ||
| {{DOMException}}. | ||
| 1. For each |permission| in |options|' [=credential type registry/Get Permissions Policy=]: |
There was a problem hiding this comment.
Shouldn't this be something like:
1. For each |interface| in |options|' <a>relevant credential interface objects</a>:
1. Let |permission| be the |interface|'s {{Credential/[[type]]}} [=credential type registry/Get Permissions Policy=].
2. If |permission| is null, continue.
3. If |document| is **not** [=allowed to use=] |permission|, return
[=a promise rejected with=] a "{{NotAllowedError}}" {{DOMException}}.
Otherwise, we're looping through all the permissions regardless of what's in our options object.
There was a problem hiding this comment.
oh yeah.. oops... 🙈
index.bs
Outdated
| [=allowed to use=] the [=publickey-credentials-create-feature|publickey-credentials-create=] | ||
| [=policy-controlled feature=] return [=a promise rejected with=] a "{{NotAllowedError}}" | ||
| {{DOMException}}. | ||
| 1. Let |permission| be |options|'s [=credential type registry/Create Permissions Policy=]. |
There was a problem hiding this comment.
Same here. Also, at this stage we still have a list of credential types to loop through. It's not until L1203 that we assert there's only one credential.
(Ideally, we'd make the permissions policy check after verifying there's only one credential, but we already shipped this and it's not that big of a deal).
There was a problem hiding this comment.
ok, yeah... I'm also unsure as to why there's a document check below... it seems unnecessary with the fully active check above.
) SHA: ee91210 Reason: push, by nsatragno Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Now allows registration of Permission Policy, and added Digital Credentials.
The following tasks have been completed:
Implementation commitment:
Preview | Diff