Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i16 Expand AssetDestroyer to also destroy AssetResources #861

Merged
merged 6 commits into from
Apr 23, 2024

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    ef949bb View commit details
    Browse the repository at this point in the history
  2. don't set validation status on deleted Asset

    Prevents the following error when deleting an AssetResource via the
    Valkyrie Transactions:
    
    `SolrDocument#get_members: undefined method 'members' for AssetResource`
    
    Setting the validation status required looking up the Asset's members
    recursively. But since we're in the middle of deleting things:
    
    1. Expected data was missing, and more importantly,
    2. We don't care about setting the Asset's validation status because
       it's being deleted
    bkiahstroud committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ae13cd1 View commit details
    Browse the repository at this point in the history
  3. use transaction to thoroughly delete members

    The Transaction ensures the members will be deleted thoroughly. For
    example, using the transaction means all the related Sipity records will
    be destroyed, which is what we want
    bkiahstroud committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    1a0a4a6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ab49f73 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    b620521 View commit details
    Browse the repository at this point in the history
  2. ensure path to logger exists

    This should fix specs that are failing in CI
    bkiahstroud committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    71683a0 View commit details
    Browse the repository at this point in the history