i16 Expand AssetDestroyer to also destroy AssetResources #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the following error when deleting an AssetResource via the Valkyrie Transactions: `SolrDocument#get_members: undefined method 'members' for AssetResource` Setting the validation status required looking up the Asset's members recursively. But since we're in the middle of deleting things: 1. Expected data was missing, and more importantly, 2. We don't care about setting the Asset's validation status because it's being deleted
The Transaction ensures the members will be deleted thoroughly. For example, using the transaction means all the related Sipity records will be destroyed, which is what we want
kirkkwang
reviewed
Apr 13, 2024
This should fix specs that are failing in CI
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expand AssetDestroyer to also delete AssetResources
ef949bb
don't set validation status on deleted Asset
ae13cd1
Prevents the following error when deleting an AssetResource via the
Valkyrie Transactions:
SolrDocument#get_members: undefined method 'members' for AssetResourceSetting the validation status required looking up the Asset's members
recursively. But since we're in the middle of deleting things:
it's being deleted
use transaction to thoroughly delete members
1a0a4a6
The Transaction ensures the members will be deleted thoroughly. For
example, using the transaction means all the related Sipity records will
be destroyed, which is what we want