Increase file level typedness at least typed: true
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` lib/vonage/namespace.rb:64: Dynamic constant references are unsupported https://srb.help/5001 64 | unless type::REQUEST_HAS_BODY || params.empty? ^^^^^^^^^^^^^^^^^^^^^^ lib/vonage/namespace.rb:80: Dynamic constant references are unsupported https://srb.help/5001 80 | self.class.request_body.update(message, params) if type::REQUEST_HAS_BODY ^^^^^^^^^^^^^^^^^^^^^^ Errors: 2 ```
The code utilizes `method_missing` to dispatch the method call dynamically. ``` lib/vonage/numbers/response.rb:6: Method error_code does not exist on Vonage::Numbers::Response https://srb.help/7003 6 | error_code == '200' ^^^^^^^^^^ Errors: 1 ``` For this kind of cases, Sorbet provides an escape hatch https://sorbet.org/docs/troubleshooting#tunsafeself
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 54 54
Lines 862 862
=======================================
Hits 859 859
Misses 3 3
Continue to review full report at Codecov.
|
|
Another good PR, @ohbarye. I'll take a look this week. |
hummusonrails
approved these changes
Oct 28, 2020
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Part of #178
Changes
As described in https://sorbet.org/docs/metrics, Sorbet recommends us to increase file-level typedness to measure adoption of Sorbet.
So I increased file-level typedness of files that have had low level typedness (
typed: ignoreortyped: false). With this change, all files get to have at leasttyped: true.