-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Sorbet typing to the gem #178
Comments
Hey! I am knew to open source development. Can I work on this issue under your able guidance? |
Hey @AnshMishra2001, welcome to open source! Please feel free to study up on Sorbet on its official website, review the existing typing in the SDK and open up a small pull request with your first attempt and we can go from there! |
Hi, I've noticed the type declarations are breaking the
These can be fixed by incorporating the |
The Vonage Ruby SDK has begun incorporating Sorbet to statically type the code, and you can contribute to it during Hacktoberfest!
We are looking for pull requests that continue the incremental adoption of Sorbet in the codebase in a thoughtful and meaningful way. How do you balance methods that take in a variety of optional parameters? How do you manage Sorbet adoption in this existing code the way it is currently structured -- adoption without doing major "code surgery" to the overall codebase.
The text was updated successfully, but these errors were encountered: