Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rules): revert TrailingCommaMultiLineRule #259

Merged
merged 2 commits into from
Jul 12, 2024
Merged

fix(rules): revert TrailingCommaMultiLineRule #259

merged 2 commits into from
Jul 12, 2024

Conversation

thislg
Copy link
Contributor

@thislg thislg commented Jul 12, 2024 •
edited
Loading

Fixes #257 #256

Temporary disable this rule (too buggy for now).

@VincentLanglet
Copy link
Owner

Can you also update the test, thanks

@VincentLanglet VincentLanglet merged commit 2daadf3 into VincentLanglet:main Jul 12, 2024
16 checks passed
@thislg thislg deleted the patch-1 branch July 12, 2024 10:36
@VincentLanglet
Copy link
Owner

Thanks, released

@thislg
Copy link
Contributor Author

thislg commented Jul 12, 2024

Thank you @VincentLanglet

@joncjordan joncjordan mentioned this pull request Nov 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing Comma MultiLine rule breaks multiline strings
2 participants
@thislg @VincentLanglet