Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code break with comma added on multiline if statements with parentheses #256

Closed
rafipiccolo opened this issue Jul 12, 2024 · 2 comments
Closed

Comments

@rafipiccolo
Copy link

rafipiccolo commented Jul 12, 2024

Rule(s) related to or rule(s) missing

dunno

Expected behavior

{% if property.rentsellType == 'property.rentsellType.rent' and (
    property.entretien or
    property.chauffage or
    property.entretienJardin
    )
%}
{% endif %}

Actual behavior

it adds a comma on the last line, after "entretienJardin"

{% if property.rentsellType == 'property.rentsellType.rent' and (
    property.entretien or
    property.chauffage or
    property.entretienJardin,
    )
%}
{% endif %}
@VincentLanglet
Copy link
Owner

Hi, can you open a PR to remove the Rule from the TwigCsFixer standard as it's a buggy rule so far ?

I wont have a computer before this night

@VincentLanglet
Copy link
Owner

VincentLanglet commented Jul 14, 2024

I'm working on a 3.0 release with BC-break needed in order to fix the rule.
If you @rafipiccolo (or @thislg) want to try it, it would be great. Both of your bug should be fixed.
You just need to use dev-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants