Introduce viaq_index_name field #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, @mijicherian I fixed the tests for #115 |
richm
reviewed
Nov 13, 2019
lukas-vlcek
force-pushed
the
viaq_index_name
branch
from
4a065db to
e73c714
Compare
lukas-vlcek
force-pushed
the
viaq_index_name
branch
from
e73c714 to
82ae6c1
Compare
|
Thanks @lukas-vlcek for your efforts. |
|
@richm PTAL |
|
@richm @mijicherian When we are going to need this new field? (i.e. when we need to cut a new model release?) |
I would say now - at least, go ahead and generate a release, and submit a PR to origin-aggregated-logging to use the new release |
lukas-vlcek
commented
Dec 16, 2019
| type: keyword | ||
| example: project.my-cool-project-in-lab04.748e92c2-70d7-11e9-b387-000d3af2d83b.2019.05.09 | ||
| description: | | ||
| Index name in which this message will be stored within the Elasticsearch. |
There was a problem hiding this comment.
@richm @jcantrill How is this going to be impacted when moving to the new data model with ES 6.x (rollover and common index; no more index per namespace/day).
There was a problem hiding this comment.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.