-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added information related to viaq_index_name field #115
Conversation
@lukas-vlcek any idea why the test failed? |
It fails because you are introducing a new field You can navigate to failed test details and search for Anyway, in cases like this it is needed to introduce an exception for this field into the test and remove this field from generated model. This means removing relevant part of JSON document. How to do it: The line where the new (fresh) index templated is generated in the test is here. Right after this the generated model is modified depending on which released model we want to compare it with (i.e. target ES version). Given, this field has been introduced just now I think we will need to remove this field for all target ES versions (the field is not part of any released model at this moment). So I would recommend adding a new method to remove relevant mapping like this and call it in the end of each if-then blocks: here, here and here. I can do it if you want. Later, when we decide which model versions this new field will be propagated to and after relevant releases are made we will remove the exception from test for those versions. |
Also something similar will have to be fixed for index patterns test somewhere here. But let's fix the index template test first. |
Can you please let me know the Licencing details of this repository? |
@mijicherian Good point, seems we forgot to add LICENSE details into this repo. I am sure it should have been AL2 but let me check if we can add it retrospectively. |
Yes, we can add it retroactively |
No description provided.