Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant Search #184

Merged
merged 18 commits into from
May 7, 2024
Merged

Variant Search #184

merged 18 commits into from
May 7, 2024

Conversation

bencap
Copy link
Collaborator

@bencap bencap commented May 2, 2024

Adds UI elements to the score set page to allow users to search for specific variants.

  • Adds an auto complete search bar above the histogram and heatmap. Users may enter text into the auto complete and any matching HGVS strings will display below it for the user to select.
Screenshot 2024-05-03 at 9 33 48 AM
  • The selected variant is now passed as a prop to the histogram and heatmap. When this prop is null, the histogram and heatmap behave as they do now. When a user selects a variant in the auto complete, the variant is passed to the visualizations as the external selection.
  • The histogram will highlight the bin containing the external selection and display a tooltip with information about the bin.
  • The heatmap will highlight both the variant square and stacked variant bar in addition to showing a tooltip with information about the variant.
Screenshot 2024-05-03 at 9 34 25 AM
  • When you mouse over the histogram while a variant is selected, the tooltip will disappear and the tooltip related to your mouse over will display. When your mouse leaves the histogram focus, the selected variant tooltip will show up again.
  • When you mouse over the heatmap while a variant is selected, an additional tooltip will display. If you mouse over the selected variant, it will disappear. When your mouse leaves the focus area for the heatmap, the additional tooltip will dissapear.
Screenshot 2024-05-03 at 9 35 14 AM
  • Selecting a variant in the auto complete will scroll to the variant's position in the heatmap, if it is not already on the screen.
  • Removed some unused code for clicks in the heatmap definition.
  • Added an emits event for clicking a square in the heatmap. If you click a variant, the variant you click will be emitted to the parent component. This event is used by the score set view to change the variant selection.

bencap added 8 commits May 1, 2024 13:56
Allows for an external selection to be used by the histogram component to display tooltip information about the selected variant.
- Add external selection support to heatmap (including tooltip rendering and auto scrolling)
- Emit a variantSelected event which can be listened to from the parent component
- Remove some unused click code and rename/refactor samplify vars
@bencap bencap added the type: enhancement Enhancement to an existing feature label May 2, 2024
@bencap bencap requested review from ashsny and jstone-dev May 2, 2024 22:45
@bencap bencap linked an issue May 2, 2024 that may be closed by this pull request
src/components/ScoreSetHistogram.vue Outdated Show resolved Hide resolved
src/components/screens/ScoreSetView.vue Outdated Show resolved Hide resolved
src/lib/mave-hgvs.ts Outdated Show resolved Hide resolved
src/components/screens/ScoreSetView.vue Outdated Show resolved Hide resolved
src/components/screens/ScoreSetView.vue Outdated Show resolved Hide resolved
@bencap
Copy link
Collaborator Author

bencap commented May 3, 2024

Screenshot 2024-05-03 at 10 32 27 AM

@ashsny
Copy link
Contributor

ashsny commented May 3, 2024

thanks for adding the variant/score. consider this one approved

@ashsny ashsny changed the base branch from jstone-uw/heatmap-deletion-fix to release-2024.1.0 May 7, 2024 04:27
@ashsny ashsny merged commit a00cdae into release-2024.1.0 May 7, 2024
@ashsny ashsny deleted the feature/bencap/164/variant-search branch May 7, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variant search
2 participants