-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variant Search #184
Merged
Merged
Variant Search #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for an external selection to be used by the histogram component to display tooltip information about the selected variant.
- Add external selection support to heatmap (including tooltip rendering and auto scrolling) - Emit a variantSelected event which can be listened to from the parent component - Remove some unused click code and rename/refactor samplify vars
Closed
ashsny
reviewed
May 2, 2024
thanks for adding the variant/score. consider this one approved |
ashsny
changed the base branch from
jstone-uw/heatmap-deletion-fix
to
release-2024.1.0
May 7, 2024 04:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI elements to the score set page to allow users to search for specific variants.
emits
event for clicking a square in the heatmap. If you click a variant, the variant you click will be emitted to the parent component. This event is used by the score set view to change the variant selection.