Request User Emails for Certain Site Features #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI Changes for VariantEffect/mavedb-api#186 |
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
from
2cf4d0e to
3c7d4de
Compare
bencap
changed the base branch from
jstone-uw/better-orcid-auth
to
feature/bencap/76/improved-admin-user-handling
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
from
b448307 to
3c7d4de
Compare
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
from
cf71f59 to
3c7d4de
Compare
…ature/bencap/21/request-user-emails
ashsny
reviewed
May 2, 2024
Base automatically changed from
feature/bencap/76/improved-admin-user-handling
to
release-2024.1.0
May 3, 2024 00:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes three main changes to better support required emails for certain site features
Display validation errors for email updates within the settings screen:
Adds toast notifications for generic API failures to the ExperimentEditor screen so that trying to add an experiment without a valid user email won't fail silently:
Adds an importable dialog prompt component to capture user emails. This component can be added to any screen that will require an email to submit data. If a user does not have an email address set on their user profile, the component will appear as an overlay:
