Request User Emails for Certain Site Features #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashsny
reviewed
Apr 23, 2024
| async def require_current_user_with_email(user: User = Depends(require_current_user)) -> User: | ||
| if user.email is None: | ||
| raise HTTPException( | ||
| status_code=status.HTTP_400_BAD_REQUEST, |
There was a problem hiding this comment.
wait, is this 400 here and 403 below?
There was a problem hiding this comment.
I originally made it 403 but then I started second guessing and thought 400 would make more sense. I'll make sure the response codes are consistent before I open it.
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
from
d3c715b to
6c1ae2b
Compare
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
2 times, most recently
from
9639603 to
a8cc7f8
Compare
bencap
changed the base branch from
jstone-uw/better-orcid-auth
to
feature/bencap/76/improved-admin-user-handling
bencap
force-pushed
the
feature/bencap/76/improved-admin-user-handling
branch
from
b4402ab to
248dbd3
Compare
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
2 times, most recently
from
705cbee to
0730a98
Compare
bencap
force-pushed
the
feature/bencap/76/improved-admin-user-handling
branch
2 times, most recently
from
2ff1a5c to
52f2d33
Compare
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
from
0730a98 to
7901a58
Compare
bencap
force-pushed
the
feature/bencap/21/request-user-emails
branch
from
7901a58 to
8b84568
Compare
ashsny
reviewed
May 2, 2024
Base automatically changed from
feature/bencap/76/improved-admin-user-handling
to
release-2024.1.0
May 3, 2024 00:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new validator on the
CurrentUserUpdateview model that validates email addresses are the correct syntax and deliverable. This was done with a new dependency: https://pypi.org/project/email-validator/Adds a new dependency
require_current_user_with_email. Essentially the same asrequire_current_user, but returns a 400 status code if the user has an unset email address associated with their user record.