Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyInstaller: Nuitkaのキャッシュパス指定を削除 #506

Merged
merged 1 commit into from
Nov 6, 2022

Conversation

y-chan
Copy link
Member

@y-chan y-chan commented Nov 6, 2022

内容

PyInstallerへの移行に伴い、Nuitkaのキャッシュパス指定がMakefileの中に残っていたので削除します。

関連 Issue

ref #439

その他

多分Dockerビルドを追加された時に一緒に入った変更だと思います。 @aoirint さんレビューいただけると心強いです...!

@y-chan y-chan changed the title Nuitkaのキャッシュパス指定を削除 PyInstaller: Nuitkaのキャッシュパス指定を削除 Nov 6, 2022
@y-chan y-chan requested a review from aoirint November 6, 2022 03:32
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 154 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 206 166 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 133 12 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 129 6 coverage-95%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
TOTAL 1237 262 coverage-79%

Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! ありがとうございます!

@y-chan
Copy link
Member Author

y-chan commented Nov 6, 2022

とりあえずPyInstallerブランチにマージしてしまいます!

@y-chan y-chan merged commit 6d2d1d9 into VOICEVOX:pyinstaller Nov 6, 2022
y-chan added a commit to SHAREVOX/sharevox_engine that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants