Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.77の新機能を導入する #771

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

qryxip
Copy link
Member

@qryxip qryxip commented Apr 1, 2024

内容

Rust 1.77に入ったf32::round_ties_even<[_]>::chunk_byを使います。
(厳密に言うと後者はもう使われていて、コピーしてきたものはただのdead codeになっているのですが)

cstrc"…"に置き換えたかったのですが、残念ながらsynがまだ対応していないためderive macroもcbindgenもまだc"…"を理解しません。そのためcstr!の置き換えは現状一つも不可能なので、コメントだけ入れています。

関連 Issue

その他

@@ -18,7 +18,7 @@ chrono = { version = "0.4.26", default-features = false }
clap = "4.0.10"
color-eyre = "0.6.2"
colorchoice = "1.0.0"
cstr = "0.2.11"
cstr = "0.2.11" # https://github.com/dtolnay/syn/issues/1502
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このコメントが解消される条件をメモっておかないてあげると、他の人も意図がわかって良さげな気がしました!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分dtolnay氏か誰かが腰を上げればスムーズに解決しそうなissueなので、長々と文脈を書かないでいいかなと思いました。cstrがどういうライブラリなのかを考えればリンク先のissueのタイトルで大体はわかるようになっていると思います。

Copy link
Member Author

@qryxip qryxip Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多分dtolnay氏か誰かが腰を上げればスムーズに解決しそうなissue

そう言ってるうちに実装されましたね。あとはクレートとしてのリリースがなされればc"…"への置き換えができるはず。
dtolnay/syn#1622

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

変更するかそのままかどちらでも良いと思います、その後マージしていただければ!

@qryxip qryxip merged commit f6e2227 into VOICEVOX:main Apr 9, 2024
36 checks passed
@qryxip qryxip deleted the introduce-new-features-of-rust-1.77 branch April 9, 2024 20:54
qryxip added a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants