Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency Rust to v1.77.1 #767

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Update dependency Rust to v1.77.1 #767

merged 1 commit into from
Mar 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 29, 2024

Mend Renovate

This PR contains the following updates:

Package Update Change
Rust patch 1.77.0 -> 1.77.1

Release Notes

rust-lang/rust (Rust)

v1.77.1

Compare Source

===========================


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust 1.77.1のリリースノートは↑で紹介されている通り。MSVC版で-Cstrip=debuginfo (デバッグ情報を消し飛ばす)は現在-Cstrip=symbols (シンボルを全部消し飛ばす)として扱われてしまうため、Windowsだけリリースビルドに対するデフォルトでの-Cstrip=debuginfoを取り止めたという変更です。

VOICEVOX COREにおいては、もともとリリースビルドは-Cstrip=symbolsなので何も変わらないはずです。

strip = true

strip = true is equivalent to strip = "symbols".

https://doc.rust-lang.org/cargo/reference/profiles.html#strip

ということで問題ないと思いますし、他に判断できる人はいないと思うのでマージしてしまいます。

@qryxip qryxip merged commit fa630ce into main Mar 30, 2024
70 checks passed
@qryxip qryxip deleted the renovate/rust branch March 30, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant