Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typecheckをデフォルトでvue-tscに #1567

Merged
merged 1 commit into from
Sep 19, 2023
Merged

typecheckをデフォルトでvue-tscに #1567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,15 +154,9 @@ typos
## 型チェック

TypeScript の型チェックを行います。
※ 現在チェック方法は 2 種類ありますが、将来的に 1 つになります。

```bash
# .tsのみ型チェック
npm run typecheck

# .vueも含めて型チェック
# ※ 現状、大量にエラーが検出されます。
npm run typecheck:vue-tsc
```

## Markdownlint
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
"lint": "eslint --ext .js,.vue,.ts *.config.* src tests build",
"fmt": "eslint --ext .js,.vue,.ts *.config.* src tests build --fix",
"markdownlint": "markdownlint --ignore node_modules/ --ignore dist/ --ignore dist_electron/ ./",
"typecheck": "tsc --noEmit",
"typecheck:vue-tsc": "vue-tsc --noEmit",
"typecheck": "vue-tsc --noEmit",
"electron:build": "cross-env VITE_TARGET=electron vite build && electron-builder --config electron-builder.config.js",
"electron:build_dir": "cross-env VITE_TARGET=electron vite build && electron-builder --config electron-builder.config.js --dir",
"electron:build_pnever": "cross-env VITE_TARGET=electron vite build && electron-builder --config electron-builder.config.js --publish never",
Expand Down
3 changes: 1 addition & 2 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ export default defineConfig((options) => {
lintCommand: "eslint --ext .ts,.vue .",
},
typescript: true,
// FIXME: vue-tscの型エラーを解決したら有効化する
// vueTsc: true,
vueTsc: true,
}),
isElectron &&
electron({
Expand Down