Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typecheckをデフォルトでvue-tscに #1567

Merged
merged 1 commit into from
Sep 19, 2023
Merged

typecheckをデフォルトでvue-tscに #1567

merged 1 commit into from
Sep 19, 2023

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Sep 19, 2023 •
edited
Loading

内容

npm run typecheckの動作をtscからvue-tscに変更します。
今まではテストで*.tsのみ型チェックしていたのを、*.vueと*.tsのコードを型チェックするようになります。

関連 Issue

スクリーンショット・動画など

その他

Vueの型エラーがいつのまにか全てなくなっていました。
修正してくださった皆様ありがとうございました！！！

@Hiroshiba Hiroshiba requested a review from a team as a code owner September 19, 2023 08:58
@Hiroshiba Hiroshiba requested review from y-chan and removed request for a team September 19, 2023 08:58
@Hiroshiba Hiroshiba mentioned this pull request Sep 19, 2023
Closed
sevenc-nanashi
sevenc-nanashi approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！
確かにvue-tscだけで両方検知できますね。

y-chan
y-chan approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@y-chan y-chan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！マージしちゃいます！

@y-chan y-chan merged commit 3903a6f into main Sep 19, 2023
@Hiroshiba Hiroshiba deleted the vue-tscをテストに追加 branch September 19, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevenc-nanashi sevenc-nanashi sevenc-nanashi approved these changes

@y-chan y-chan y-chan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hiroshiba @y-chan @sevenc-nanashi