-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: コンテキストメニューにアクセント句の削除を追加 #1554
Merged
Hiroshiba
merged 7 commits into
VOICEVOX:main
from
thiramisu:context-menu-to-create-accent-phrase
Sep 19, 2023
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4a6596b
feat: コンテキストメニューにアクセント句の削除を追加
thiramisu a990546
`COMMAND_DELETE_ACCENT_PHRASE`を定義
thiramisu 00e33a5
test: 削除のe2eテストを追加
thiramisu 51f694c
test: e2eテストのlocatorを修正
thiramisu 216526d
Merge branch 'VOICEVOX:main' into context-menu-to-create-accent-phrase
thiramisu 66d26b7
feat: 他のアクセント句の自動再調整をやめる
thiramisu 423ea1f
feat: 全項目で表示されるようにする
thiramisu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import { test, expect } from "@playwright/test"; | ||
|
||
import { navigateToMain } from "../navigators"; | ||
|
||
test.beforeEach(async ({ page }) => { | ||
const BASE_URL = "http://localhost:5173/#/home"; | ||
await page.setViewportSize({ width: 800, height: 600 }); | ||
await page.goto(BASE_URL); | ||
}); | ||
|
||
test("詳細調整欄のコンテキストメニュー", async ({ page }) => { | ||
await navigateToMain(page); | ||
await page.waitForTimeout(100); | ||
|
||
// 削除 | ||
await page.getByRole("textbox", { name: "1行目" }).click(); | ||
await page.getByRole("textbox", { name: "1行目" }).fill("1234"); | ||
await page.getByRole("textbox", { name: "1行目" }).press("Enter"); | ||
await page.getByText("サンジュウ").click({ | ||
button: "right", | ||
}); | ||
await page | ||
.getByRole("listitem") | ||
.filter({ has: page.getByText("削除") }) | ||
.click(); | ||
await page.waitForTimeout(100); | ||
await expect(page.getByText("サンジュウ")).not.toBeVisible(); | ||
await expect(page.getByText("ニヒャク")).toBeVisible(); | ||
await expect(page.getByText("ヨン")).toBeVisible(); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
COMMAND_CHANGE_SINGLE_ACCENT_PHRASE
、やってることはsetAccentPhrases
だけど、名称と合ってないんですよね・・・。いつか直してあげたいですね・・・。