feat: コンテキストメニューにアクセント句の削除を追加 #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Hiroshiba
reviewed
Sep 15, 2023
Hiroshiba
reviewed
Sep 19, 2023
Hiroshiba
reviewed
Sep 19, 2023
|
レビューありがとうございました。 |
Hiroshiba
approved these changes
Sep 19, 2023
Comment on lines
+2412
to
+2415
| commit("COMMAND_CHANGE_SINGLE_ACCENT_PHRASE", { | ||
| audioKey, | ||
| accentPhrases: newAccentPhrases, | ||
| }); |
There was a problem hiding this comment.
COMMAND_CHANGE_SINGLE_ACCENT_PHRASE、やってることはsetAccentPhrasesだけど、名称と合ってないんですよね･･･。
いつか直してあげたいですね･･･。
|
問題ないと思うのでマージします！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
#1542 を実装しようと思いましたが、そもそもコンテキストメニューがないのでいきなり全部実装は少しハードルが高そうに見えました。
ということで、とりあえず簡単に実装できそうな「削除」機能を実装して、後から「挿入」機能を付け足そうかなと思いました。
関連 Issue
上記のための一部です。
実装中に見つけたバグです（未解決）。
スクリーンショット・動画など
その他