Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

厳密にはundefinedではなくnullだったのを修正 #1485

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

thiramisu
Copy link
Contributor

@thiramisu thiramisu commented Aug 5, 2023

内容

VSCode上で「nullの可能性があります」と警告が出ていたので比較を厳密でなくしました(!==から!=へ)。
バグ自体は直ったままなのを確認しました。挙動に変更はありません。

関連 Issue/PR

スクリーンショット・動画など

image

その他

@thiramisu thiramisu requested a review from a team as a code owner August 5, 2023 19:12
@thiramisu thiramisu requested review from Hiroshiba and removed request for a team August 5, 2023 19:12
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

起こってしまっていたかという気持ちです・・・。修正ありがとうございます。
そろそろeslint-config-airbnb-base辺りを導入しても良いかもですね・・・。(eqeqeqは緩めて)

@Hiroshiba Hiroshiba merged commit edf554a into VOICEVOX:main Aug 6, 2023
@thiramisu thiramisu deleted the fix-nullable-warning branch August 6, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants