Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
VSCode上で「nullの可能性があります」と警告が出ていたので比較を厳密でなくしました(
!==
から!=
へ)。バグ自体は直ったままなのを確認しました。挙動に変更はありません。
関連 Issue/PR
(個人的には厳密演算子派で、なんならif文の条件式にはboolean以外含めるべきではないとすら思っています。が、nullOrUndefinedに限っては、例えば
{ text: string | undefined } | null
を返す外部の関数hogeがあった場合にif ((hoge()?.text ?? undefined) === undefined)
みたいな記述は微妙なのでif (hoge()?.text)という記述になり、falsyな""
(空文字列)をスルーしてしまう可能性があるのを懸念しています。それを見越してかeslintのeqeqeqではnullとの比較だけは厳密でなくても良いオプションがあるみたいです)スクリーンショット・動画など
その他