Hypothesis #17
Merged
Hypothesis #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| outfile = 'foo' | ||
| filter_on_index_quality_interleaved(names[0], names[1], names[2], outfile, _min) | ||
| # version using the jip module itself not working | ||
| #cmd = sh.Command('jip_modules/interleaved_index_filter.jip') |
There was a problem hiding this comment.
uncommenting the sh.Command parts and commenting the filter_on_index_quality_interleaved worked for me, however, it was vastly slower(5 seconds with function call compared to 60 seconds using sh)
I don't know why that is yet
|
Please merge this and I will start working on the latter parts of the pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I broke something as these were passing before, so I'm doing this PR rather than introducing a failing build into the filter-trim branch.