Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel blast improvements #59

Merged
merged 8 commits into from
Aug 31, 2015
Merged

Parallel blast improvements #59

merged 8 commits into from
Aug 31, 2015

Conversation

necrolyte2
Copy link
Member

Still working on fixing up documentation and a few extra tests to ensure things are being called right

@necrolyte2 necrolyte2 self-assigned this Aug 31, 2015
@necrolyte2 necrolyte2 added this to the v1.2.0 milestone Aug 31, 2015
@necrolyte2
Copy link
Member Author

@averagehat I think this is good to go for now. Review and merge please

] + shlex.split(diamondoptions)
cmd = sh.Command('parallel')
run(cmd, args, inputfile, outfile)
'-a', '{}.{#}', ';', dmnd_path, 'view', '{}.{#}.daa'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little cryptic I would mention the need to do diamond view in the docstring, maybe mention what {#} is doing

@necrolyte2
Copy link
Member Author

So I thought I checked the output of the command to make sure the .tsv being produced was correct but apparently I didn't. So i'm back to waiting for diamond to finish so I can verify it's correctness

@necrolyte2
Copy link
Member Author

Alright this seems to work.
Maybe we can build in a more functional test now that I realized how to make a super small diamond database

#. Get a small sequence file in dna format call it smallprotein.dna.fa
#. Translate it to protien call it smallprotein.rna.fa
#. diamond makedb --in smallprotein.rna.fa --db smallprotiendb
#. parallel_blast smallprotien.dna.fa out.tsv --db $PWD/smallprotiendb --blast_exe diamond --task blastx
#. Compare out.tsv to same output from running diamond manually
#. `echo -e "localhost\n127.0.0.1" > nodefile; export PBS_NODEFILE=$PWD/nodefile;``
#. Rerun parallel_blast command above and it should end up with same output

@averagehat
Copy link
Contributor

I'll merge this unless you want to add a functional test.

@necrolyte2
Copy link
Member Author

I think you can merge it. I won't get to the functional tests, but seems like it will be a good idea to add them at some point(minus the parallel portion because I don't know how that would work doing multiple hosts)

averagehat added a commit that referenced this pull request Aug 31, 2015
@averagehat averagehat merged commit 64c555f into dev Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants