-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel blast improvements #59
Conversation
… after it runs since it uses daa format
… static args. parallel_diamond improvements
@averagehat I think this is good to go for now. Review and merge please |
] + shlex.split(diamondoptions) | ||
cmd = sh.Command('parallel') | ||
run(cmd, args, inputfile, outfile) | ||
'-a', '{}.{#}', ';', dmnd_path, 'view', '{}.{#}.daa' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little cryptic I would mention the need to do diamond view
in the docstring, maybe mention what {#} is doing
So I thought I checked the output of the command to make sure the .tsv being produced was correct but apparently I didn't. So i'm back to waiting for diamond to finish so I can verify it's correctness |
…handle short args. TODO
Alright this seems to work. #. Get a small sequence file in dna format call it smallprotein.dna.fa |
I'll merge this unless you want to add a functional test. |
I think you can merge it. I won't get to the functional tests, but seems like it will be a good idea to add them at some point(minus the parallel portion because I don't know how that would work doing multiple hosts) |
Parallel blast improvements
Still working on fixing up documentation and a few extra tests to ensure things are being called right