Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctleptop replaces gaps with Ns #99

Open
averagehat opened this issue Mar 16, 2016 · 3 comments
Open

ctleptop replaces gaps with Ns #99

averagehat opened this issue Mar 16, 2016 · 3 comments

Comments

@averagehat
Copy link
Contributor

I'm not convinced this is correct behaviour. In particular this may get interpreted as an ambiguous base when it is not. Probably the gap should just be left as it is.

@averagehat
Copy link
Contributor Author

It looks like ctleptop then marks these Ns as GAPFOUND. But this conflates "true" Ns with gaps.

@necrolyte2 necrolyte2 added this to the MAAPS milestone Mar 16, 2016
@InaMBerry
Copy link

Hi Michael,
I don't remember exactly why we had gaps replaced by Ns but I know gaps were messing things up and at the time what I needed from MAAPs was not affected by the replacement. However, I know you and I talked about adding things to MAAPs and this might have to be adjusted. I think we need to sit down and go through everything, that will help make the correct decision regarding gaps and other things as well. When it comes to the output it is just the numbering of amino acids that is messed up, it is something you noticed long time ago. But it is something we can discuss later as well. When I come back from Thailand I should have more time and we can get going on this properly.

Thanks for your help!
Ina

@averagehat
Copy link
Contributor Author

Okay, good deal Ina, I'd forgotten some of that. I forgot that you're in
Thailand next week! Have a fruitful trip.

Mike

On Thu, Mar 17, 2016 at 10:00 AM, InaMBerry [email protected]
wrote:

Hi Michael,
I don't remember exactly why we had gaps replaced by Ns but I know gaps
were messing things up and at the time what I needed from MAAPs was not
affected by the replacement. However, I know you and I talked about adding
things to MAAPs and this might have to be adjusted. I think we need to sit
down and go through everything, that will help make the correct decision
regarding gaps and other things as well. When it comes to the output it is
just the numbering of amino acids that is messed up, it is something you
noticed long time ago. But it is something we can discuss later as well.
When I come back from Thailand I should have more time and we can get going
on this properly.

Thanks for your help!
Ina


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#99 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants