Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_total_order #5

Open
Utumno opened this issue Jun 26, 2015 · 0 comments
Open

get_total_order #5

Utumno opened this issue Jun 26, 2015 · 0 comments
Assignees
@Utumno
Labels
API

Comments

@Utumno
Copy link
Owner

Utumno commented Jun 26, 2015

Getting the active plugins and load order should be an atomic operation:

  • existence and validity checks are needlessly repeated
  • if LO changed we need to check active, as plugins may have been removed for instance
  • if active changed we need to add active files to load order if not there (at least that is what current implementation does)
  • etc
@Utumno Utumno added the API label Jun 26, 2015
@Utumno Utumno self-assigned this Jun 27, 2015
Utumno added a commit that referenced this issue Jun 27, 2015
@Utumno
[7.0.1]Avoid duplicate existence checks when saving active plugins:
b2a5c5d 
Under #5
Under #3
Utumno added a commit that referenced this issue Jun 27, 2015
@Utumno
[7.1.0]Return active plugins in plugins.txt order HACK:
c34973d 
Under #4.
Under #5 - notice we need a valid LO passed in for TESV.
ActivePlugins should be a vector but I can't go into this now - wait till
the code is clean.
Note that I also inversed the order of the if for usual case to come first.
This should be a method of game (readPluginsTxt) - see #9.
Utumno added a commit that referenced this issue Jun 27, 2015
@Utumno
[7.5.0]Saving loadorder txt on additions and creating it if does not …
78e1b51 
…exist:

Closes #10.

Another monkey patch - bool _saveActive - and another justification for
#5.
Utumno added a commit that referenced this issue Jul 13, 2015
@Utumno
[7.5.0]Saving loadorder txt on additions and creating it if does not …
5b71e80 
…exist:

Closes #10.

Another monkey patch - bool _saveActive - and another justification for
#5.
@Utumno Utumno mentioned this issue Nov 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Utumno Utumno

Labels
API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Utumno