bugfix/mapping source connectors in destination cli commands #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how did we not catch this in a test? |
rbiseck3
force-pushed
the
roman/bugfix-fsspec-source-dest-config
branch
4 times, most recently
from
4017576 to
1282113
Compare
|
@ryannikolaidis, these will all be covered in the destination tests added in this PR: #1777 |
in the meantime, are there test instructions I can use to confirm it was broken before and fixed now? |
ahmetmeleq
reviewed
Oct 20, 2023
|
Can we confirm we got these? If yes, LGTM |
|
Test instructions: Run any fsspec source connector with any destination connector (other than s3). It'll fail to map the fsspec config. |
rbiseck3
force-pushed
the
roman/bugfix-fsspec-source-dest-config
branch
from
1282113 to
51119e6
Compare
ryannikolaidis
approved these changes
Oct 20, 2023
rbiseck3
added a commit
that referenced
this pull request
Oct 20, 2023
Due to the dynamic nature of how the source connector is called when a destination command is invoked, the configs need to be mapped and the fsspec config needs to be dynamically added based on the type of runner being used. This code was added to all currently supported destination commands.
rbiseck3
added a commit
that referenced
this pull request
Oct 20, 2023
Due to the dynamic nature of how the source connector is called when a destination command is invoked, the configs need to be mapped and the fsspec config needs to be dynamically added based on the type of runner being used. This code was added to all currently supported destination commands.
rbiseck3
added a commit
that referenced
this pull request
Oct 20, 2023
Due to the dynamic nature of how the source connector is called when a destination command is invoked, the configs need to be mapped and the fsspec config needs to be dynamically added based on the type of runner being used. This code was added to all currently supported destination commands.
rbiseck3
added a commit
that referenced
this pull request
Oct 21, 2023
Due to the dynamic nature of how the source connector is called when a destination command is invoked, the configs need to be mapped and the fsspec config needs to be dynamically added based on the type of runner being used. This code was added to all currently supported destination commands.
rbiseck3
added a commit
that referenced
this pull request
Oct 23, 2023
Due to the dynamic nature of how the source connector is called when a destination command is invoked, the configs need to be mapped and the fsspec config needs to be dynamically added based on the type of runner being used. This code was added to all currently supported destination commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the dynamic nature of how the source connector is called when a destination command is invoked, the configs need to be mapped and the fsspec config needs to be dynamically added based on the type of runner being used. This code was added to all currently supported destination commands.