expand fsspec downstream connectors #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbiseck3
force-pushed
the
roman/expand-fsspec-downstream-connectors-2
branch
2 times, most recently
from
53c27aa to
5e5c63c
Compare
rbiseck3
force-pushed
the
roman/expand-fsspec-downstream-connectors-2
branch
4 times, most recently
from
9be95d3 to
c4b6a60
Compare
rbiseck3
force-pushed
the
roman/expand-fsspec-downstream-connectors-2
branch
from
1f8c1b6 to
a888fdc
Compare
…1938) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <[email protected]>
rbiseck3
force-pushed
the
roman/expand-fsspec-downstream-connectors-2
branch
from
ad5144f to
463f4c3
Compare
| @@ -132,6 +132,13 @@ def __post_init__(self): | |||
| self.file_path = "" | |||
| return | |||
|
|
|||
| # dropbox paths can start with slash | |||
|
|
||
| # Simply check the number of files uploaded | ||
| expected_num_files=1 | ||
| num_files_in_gcs=$(gcloud storage ls "$DESTINATION_GCS"/example-docs/ | wc -l ) |
There was a problem hiding this comment.
good enough for now, but can you add a low priority ticket to remove the need for dependencies like gcloud...etc to test these? would be nice if a user didn't need to install all of these just to run the tests. could work by just doing an ls on the output test folder.
There was a problem hiding this comment.
Created one here: drop dependency on cloud CLIs in CI
There was a problem hiding this comment.
Will also have to investigate how to clean up the created folders without the CLIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing PR 1383