fix: handle errors from Tesseract #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain regions of a document are failing ocr with this error: `pytesseract.pytesseract.TesseractError: (-8, 'Estimating resolution as 1250')` When I try the same region on the CLI, I get: ``` $ tesseract bad_tile.jpeg output Estimating resolution as 1813 Floating point exception ``` Whatever the root cause, let's catch this error and return an empty string.
|
Looks like those ingest tests have been failing on main for a while, so I'm assuming we can ignore here. |
Yeah, that just indicates the current version of unstructured-inference would produce different outputs if the ingests tests are run. Hopefully, they are good different outputs! |
shreyanid
approved these changes
Aug 9, 2023
cragwolfe
added a commit
to Unstructured-IO/unstructured
that referenced
this pull request
Aug 10, 2023
* build(release): bump unstructured-inference Related to downstream issue: Unstructured-IO/unstructured-api#182 And upstream PR: Unstructured-IO/unstructured-inference#165 --------- Co-authored-by: Shreya Nidadavolu <[email protected]>
shreyanid
added a commit
to Unstructured-IO/unstructured-api
that referenced
this pull request
Aug 14, 2023
Related to downstream issue: #182 And upstream PR: Unstructured-IO/unstructured-inference#165 * remove test_parallel_mode_correct_result * dropped the file_directory field from elements metadata
cragwolfe
reviewed
Aug 22, 2023
|
|
||
| try: | ||
| return agent.detect(cropped_image) | ||
| except tesseract.TesseractError: |
There was a problem hiding this comment.
add a logger.warn("<something", exc_info=True)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain regions of a document are failing ocr with this error:
pytesseract.pytesseract.TesseractError: (-8, 'Estimating resolution as 1250')(for some value)When I try the same region on the CLI, I get:
Whatever the root cause, let's catch this error and return an empty string.