Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(release): bump unstructured #183

Merged
merged 7 commits into from
Aug 14, 2023
Merged

build(release): bump unstructured #183

merged 7 commits into from
Aug 14, 2023

Conversation

shreyanid
Copy link
Contributor

Related to downstream issue:

#182

And upstream PR:

Unstructured-IO/unstructured-inference#165

@shreyanid shreyanid requested a review from yuming-long August 11, 2023 17:05
@@ -921,6 +921,7 @@
"[{'type': 'UncategorizedText',\n",
" 'element_id': 'db1ca22813f01feda8759ff04a844e56',\n",
" 'metadata': {'filename': 'family-day.eml',\n",
" 'file_directory': '/Users/shreyanid/Documents/all-unstructured/unstructured-api/sample-docs',\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this field has been in the metadata for a while - did something just change for it to show here? This will probably get us into trouble with make check-notebooks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly what's happening :') Not sure what just changed, this commit was thrown out as a possibility. But it isn't happening on the current main branch of api, so that means some package bump (likely unstructured) caused the change. Would appreciate some help debugging where the change came from, and why the difference in file directory is not happening locally but happening in CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this release comparison it doesn't seem like anything recently changed related to the file_directory field

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's a fun one! I have some cycles now to take a look as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think it is that commit. Here it looks like file_directory will be set whenever a filename is present, and that commit will have us sending metadata_filename all the time. All the different filename params confuse me, but tldr is that we should remove that field like the ones over here.

shreyanid and others added 4 commits August 14, 2023 12:02
adding tidy-notebooks to CI to resolve check-notebooks error due to file directory field divergence. will remove before merging
Copy link
Collaborator

@awalker4 awalker4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm optimistically assuming the notebook check passed this time 😄

@shreyanid shreyanid marked this pull request as ready for review August 14, 2023 19:57
@shreyanid shreyanid merged commit f491b85 into main Aug 14, 2023
@shreyanid shreyanid deleted the api-bump branch August 14, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants