-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(release): bump unstructured #183
Conversation
@@ -921,6 +921,7 @@ | |||
"[{'type': 'UncategorizedText',\n", | |||
" 'element_id': 'db1ca22813f01feda8759ff04a844e56',\n", | |||
" 'metadata': {'filename': 'family-day.eml',\n", | |||
" 'file_directory': '/Users/shreyanid/Documents/all-unstructured/unstructured-api/sample-docs',\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this field has been in the metadata for a while - did something just change for it to show here? This will probably get us into trouble with make check-notebooks
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly what's happening :') Not sure what just changed, this commit was thrown out as a possibility. But it isn't happening on the current main branch of api, so that means some package bump (likely unstructured) caused the change. Would appreciate some help debugging where the change came from, and why the difference in file directory is not happening locally but happening in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this release comparison it doesn't seem like anything recently changed related to the file_directory field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's a fun one! I have some cycles now to take a look as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding tidy-notebooks to CI to resolve check-notebooks error due to file directory field divergence. will remove before merging
…structured-api/unstructured-api/sample-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm optimistically assuming the notebook check passed this time 😄
Related to downstream issue:
#182
And upstream PR:
Unstructured-IO/unstructured-inference#165