Document obl:agent for English passives #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also made small tweaks to the universal docs. Will leave this open for a couple days in case @dan-zeman wants to do a sanity check before I merge. |
|
Does this all need a link here https://universaldependencies.org/u/dep/obl-agent.html or does that get automatically generated once this is merged? |
|
|
dan-zeman
reviewed
Dec 26, 2024
Skimmed through the changes, seems good to me (except for one comment on subject-verb agreement). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per UniversalDependencies/UD_English-EWT#290, English treebanks have been adopting
obl:agent. This PR adds it to the English docs.