Implement the first half of the nmod:desc change... maybe? #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschneid
requested changes
Dec 25, 2024
|
Sounds good. I also found one other, in |
nschneid
approved these changes
Dec 25, 2024
nschneid
reviewed
Dec 26, 2024
|
LGTM |
|
Excellent, so, I'll squash & merge? |
|
Sure |
|
Thank you, I will do that now, then
…On Thu, Dec 26, 2024 at 11:38 AM Nathan Schneider ***@***.***> wrote:
Sure
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2AYWLA7R54AIOJ6MKQTKT2HQ5IJAVCNFSM6AAAAABUFTJTAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRSHE3TQNBXGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
The validator caught a couple errors: http://quest.ms.mff.cuni.cz/udvalidator/cgi-bin/unidep/validation-report.pl?UD_English-PUD |
|
Oops, that was careless of me. Thanks for pointing those out. Speaking of the validator, worth figuring out some of the other ExtPos tags which aren't there yet? |
|
Sure, do you want to take a crack at it? |
|
not really but i guess no one else will
…On Thu, Dec 26, 2024 at 3:34 PM Nathan Schneider ***@***.***> wrote:
Sure, do you want to take a crack at it?
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA2AYWISHBISSE3ZPREMDA32HRY7VAVCNFSM6AAAAABUFTJTAWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRTGEYTGNZQHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
there's also ParTUT, which has several such fixed expressions... does anyone have ownership of that? |
@msang appears to be the maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60
@nschneid does this look correct? if so, i will go back and do the second half as well