Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity master darwin stop world diagnostics #1325

Open
wants to merge 944 commits into
base: unity-main
Choose a base branch
from

Conversation

joncham
Copy link
Member

@joncham joncham commented Jul 28, 2020

No description provided.

eneko-unity and others added 30 commits May 29, 2019 14:53
…ort socket is opened after stopping the debugger thread and start a new debugger thread
The default value for `DefaultConnectionLimit`, which is set based on
the `DefaultPersistentConnectionLimit` value should be 2 for all
non-ASP.NET applications.

So for the unityaot profile, used with IL2CPP, use the value of 2.
…ction-limit

Use the non-server default connection limit for unityaot (case 1156607)
…s-depth

Fix liveness recursion issue (case 1137077). Cherry-pick of https://g…
…r-async-crash

Fix crash during async debugging (case 1153078). Apply partial patch …
…verflow-windows-sp-address

Update RSP with fault address for stack overflow (case 1148592)
…r-perf

Initial work to allow debugger attaching without performance impact.
This change builds the class library code to implement the
`NamedPipeClientStream` class in the unityaot profile on Windows. For
the time being, we will not implement this class for non-Windows
platforms, since that requires the Mono.Posix.dll assembly and a native
library as well.

We may consider adding support on Posix platforms in the future.
Implement NamedPipeClientStream in the unityaot profile (case 1159863)
Correct call to bootstrap script for wsl build
These dummy types were added in 0e66d19
so that the `ProcessImportedType` method could be added to the
`IDataContractSurrogate` interface properly. However, the types were not
put in the proper namespace.

Recent changes to the profile stubber to handle overloaded methods
correctly caused an additional `ProcessImportedType` method to be
incorrectly stubbed in. This change allows the profile stubber to
correctly notice that this method exists, and not stubbing is done.
…om-unityaot

Put dummy types used in ProcessImportedType in the proper namespace
On macOS and FAT32 partitions, we will sometimes get this inode value
for more than one file. It means the file is empty.  When this happens,
the hash table of file shares becomes corrupt, since more then one file
has the same inode. Instead, let's assume it is always fine to share
empty files. (Unity case 950616).
…le-new-mono

Handle the empty file inode on macOS and FAT32
…_Windows

Fixing odbc library lookup on windows.
Automate creating stevedore mbe artifact
GeoffroyAubey and others added 26 commits June 23, 2020 12:33
…undefined on darwin but was added recently which leads to unexpected behavior

Signed-off-by: Tautvydas Žilys <[email protected]>
Signed-off-by: Tautvydas Žilys <[email protected]>
Add Apple silicon slice to Mono runtime built for macOS
…e data in the windows registry. (case 1256569)
…6569

Fixing a hang that would occur when there is incorrectly set time zon…
Retry running bee several times if it fails
…gc-perf-regression

Pickup BDWGC fix for GC_retry_signals performance regression (case 1255866)
…y_error_convert_to_exception

* mono_custom_attrs_construct_by_type allows unity to have a chance at handling the error if one arises instead of fatally asserting
* mono_unity_error_convert_to_exception allows unity to take the provided MonoError and fetch the MonoException object within to log into the editor as the exception that was thrown.

This change has associated unity changes in order to fix (case 1255935)
…5935

Exposing functions: mono_custom_attrs_construct_by_type and mono_unit…
…e can do whatever is necessary to transition to executing managed code, like marking JIT memory executable on macOS ARM64.
…lvirt Finalize() on the object and if it didn't have a finalizer, it would call Object::Finalize(). However, since now we use mono_method_invoke with a concrete method, we crash if it's null. So we just
…r-fix-2

Use mono_runtime_invoke to invoke finalizers.
…RM64 by adding a known TLS offset of 224 (0xE0).
Fixes Fogbugz ticket 1261388.
Impl sticks close to current Mono Btls implementation on _master_ - the implementation on our fork has the same issues as prior to this fix and throws NotImplementedException
…s-implement-chainstatus

X509ChainImplUnityTls reports status now
…reaking the CreateLocal -> WinRTFallback -> CreateLocal loop by calling GetLocalTimeZoneInfoWinRTFallback instead of accessing Local from within FindSystemTimeZoneByIdWinRTFallback fixes both issues.

Need to make sure we don't duplicate the timezone and create a new local when we already have one.
…-timezone

The fix for 1256569 broke a test. Partial revert
…evedore

Repackage stevedore artifact to remove builds in folder structure
@joncham joncham self-assigned this Jul 28, 2020
@joncham joncham force-pushed the unity-master-darwin-stop-world-diagnostics branch from 86c9a17 to 30a5a3d Compare July 29, 2020 13:27
@unity-cla-assistant
Copy link
Collaborator

unity-cla-assistant commented May 19, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 10 committers have signed the CLA.

✅ ashwinimurt
✅ UnityAlex
✅ scott-ferguson-unity
✅ AndreasReich
❌ Joe Valenzuela
❌ jechter
❌ TautvydasZilys
❌ GeoffroyAubey
❌ unpacklo
❌ thaystg


Joe Valenzuela seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.