Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS offset lookup on macOS ARM64 #1317

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

TautvydasZilys
Copy link

Currently, when running Mono on macOS ARM64, this message appears in the log:

Found new TLS offset at 224

Turns out, Mono hardcodes a byte offset into internal pthread TLS data structure in order to be able to retrieve TLS values from within other threads. This change merely updates the hardcoded offset on macOS to match the reality. This change affects only macOS ARM64 builds.

This whole code has been removed from upstream, so when we merge, we don't need to reapply this change.

…RM64 by adding a known TLS offset of 224 (0xE0).
@TautvydasZilys TautvydasZilys merged commit fb1dbb3 into unity-master Jul 13, 2020
@TautvydasZilys TautvydasZilys deleted the macos-arm64-tlsoffset branch July 13, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants