Cleanup PoolManager comments and Readme #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
commented
May 24, 2024
| emit Initialize(id, key.currency0, key.currency1, key.fee, key.tickSpacing, key.hooks); | ||
| } | ||
|
|
||
| /// @inheritdoc IPoolManager | ||
| function unlock(bytes calldata data) external override noDelegateCall returns (bytes memory result) { |
There was a problem hiding this comment.
Moved this to the top of the file, to have initialize, modify, swap, donate all together
snreynolds
commented
May 24, 2024
| @@ -264,10 +263,16 @@ contract PoolManager is IPoolManager, ProtocolFees, NoDelegateCall, ERC6909Claim | |||
| key.hooks.afterDonate(key, amount0, amount1, hookData); | |||
| } | |||
|
|
|||
| /// @inheritdoc IPoolManager | |||
| function sync(Currency currency) public returns (uint256 balance) { | |||
There was a problem hiding this comment.
moved this to be with take/settle/burn/mint
snreynolds
commented
May 24, 2024
| @@ -73,8 +73,9 @@ import {CustomRevert} from "./libraries/CustomRevert.sol"; | |||
| // 444444444 444 | |||
| // 44444 444 | |||
| // 444 | |||
| /// @notice Holds the state for all pools | |||
There was a problem hiding this comment.
this has been bugging me for DAYS lol
|
Forge code coverage:
|
saucepoint
approved these changes
May 24, 2024
hensha256
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes