Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places that could use extra explanatory comments IMO #709

Closed
marktoda opened this issue May 24, 2024 · 2 comments
Closed

Places that could use extra explanatory comments IMO #709

marktoda opened this issue May 24, 2024 · 2 comments
Labels

Comments

@marktoda
Copy link
Contributor

Component

Singleton

Describe the suggested feature and problem it solves.

  • Why events are emitted so high up in the operation functions (i.e. because they need to be before afterXYZ to keep ordering)
  • general CA explainer in swap + modifyPosition when we update callerDelta and hookDelta
  • in swap we say "// if the hook doesnt have the flag to be able to return deltas, hookDelta will always be 0." above the hook call, but think this should be a few lines below when we check the return value
  • why do we need the _swap internal function when its only called once?
  • " // subtraction must be safe" comments could use more explanation - not sure what they mean here

Describe the desired implementation.

No response

Describe alternatives.

No response

Additional context.

No response

Copy link

linear bot commented May 24, 2024

@snreynolds
Copy link
Member

Closing - most of this fixed in #715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants