5.1 #1691
Merged
5.1 #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrating the new curaengine repo in our cura-build-environment, proofed difficult due to the way how we are passing compiler, flags and settings in that repo. Since curaengine relies on arcus and arcus is now a Conan package it can't find the pre-compiled binaries for those flags and settings. Because curaengine can be build/used separately from cura. The current plan is to create a curaengine package. Which will build binaries when pushed to main but does a simple export-pkg on other branches this should limit the amount of data to our Artifactory server. Caching between pipeline runs should further limit this. The build artifacts are then collected in cura-build-environment and installed in the correct location in those scripts. Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
This commit should be reverted before the actual PR Contributes to CURA-9365
This needs to be done for each job. Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Superseded by .clang-format Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Needed due to or lengthy versions Contributes to CURA-9365
This should allow for uniform naming, versioning and keep things maintainable Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
It might not work with reusable flows. Contributes to CURA-9365
This is a workaround to allow further development of this Action until we have the JFrog server up and running. Contributes to CURA-9365
This reverts commit 3cd1c65.
Maybe we should find the first non-empty path? Would become a lot more complex then though. Contributes to issue CURA-9331.
CURA-9225 Co-authored-by: Ghostkeeper <[email protected]>
This reverts commit 02cbe41.
Don't call the function to calculate the outlines for this layer twice. Also make the out for the exceptional state an early-out. part of CURA-9225
…_on_empty [CURA-9331] Check if all paths are empty in supposedly non-empty wall-path.
At least one negative layer, which can only happen when raft is active (and if a raft is active and a prime tower, the prime tower does start on the raft) was observed to happen at this point in one test. Probably goes wrong somewhere else, but can't hurt to apply some defensive programming here. (As it should just not happen.) part of CURA-9225
[CURA-9225] 'Prime' for mutliple extruders in Raft
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Before this fix, the distance to the intersection was measured by the distance to the _line_ goint through some points A and C on the poly-like in question. However, only the _line-segment_ is of course on the poly-like, anything 'just' on the line could be very far indeed from the intended location. Luckily there was already a method that checks this, so it was just a question of swapping out the line method for the line-segment method. (As an aside: Note the parameter-ordering -- that has to be different between the two methods for some reason, since the method now used has the point in the middle instead of at the beginning?) CURA-9425
Unit Test Results 1 files + 1 1 suites +1 1m 24s ⏱️ + 1m 24s For more details on these failures, see this check. Results for commit b9cadd5. ± Comparison against base commit d370e55. ♻️ This comment has been updated with latest results. |
41 tasks
| branches: | ||
| - main | ||
| - 'CURA-*' | ||
| - '[1-9]+.[0-9]+' |
There was a problem hiding this comment.
Suggested change
| - '[1-9]+.[0-9]+' | |
| - '[0-9]+.[0-9]+' |
GitVersion.yml
Outdated
| is-mainline: false | ||
| pre-release-weight: 0 | ||
| release: | ||
| regex: ^[\d].[\d]$ |
There was a problem hiding this comment.
Suggested change
| regex: ^[\d].[\d]$ | |
| regex: ^[0-9]+.[0-9]+$ |
casperlamboo
approved these changes
Jul 13, 2022
Update branch names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Ultimaker/Cura#12708 for all the PR's
Failing tests are unrelated to this PR