[CURA-9425] Distance to moved point should be w.r.t. segment. #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, the distance to the intersection was measured by the distance to the _line_ goint through some points A and C on the poly-like in question. However, only the _line-segment_ is of course on the poly-like, anything 'just' on the line could be very far indeed from the intended location. Luckily there was already a method that checks this, so it was just a question of swapping out the line method for the line-segment method. (As an aside: Note the parameter-ordering -- that has to be different between the two methods for some reason, since the method now used has the point in the middle instead of at the beginning?) CURA-9425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the distance to the intersection was measured by the distance to the line going through some points A and C on the poly-like in question. However, only the line-segment is of course on the poly-like, anything 'just' on the line could be very far indeed from the intended location. Luckily there was already a method that checks this, so it was just a question of swapping out the line method for the line-segment method.
(As an aside: Note the parameter-ordering -- that has to be different between the two methods for some reason, since the method now used has the point in the middle instead of at the beginning?)