Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UXARRAY/uxarray#846 #847

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix UXARRAY/uxarray#846 #847

merged 1 commit into from
Jul 10, 2024

Conversation

kjnam
Copy link
Contributor

@kjnam kjnam commented Jul 10, 2024

Addresses #846

Overview

The code to rename UGRID topology names does not use attributes to check names. This bug ignores edge and face coordinates names to rename.
Also, there is a typo in the face coordinates renaming, which will replace names with the wrong variables.

PR Checklist

General

  • An issue is linked created and linked
  • Add appropriate labels
  • Filled out Overview and Expected Usage (if applicable) sections

Testing

  • Adequate tests are created if there is new functionality
  • Tests cover all possible logical paths in your function
  • Tests are not too basic (such as simply calling a function and nothing else)

Documentation

  • Docstrings have been added to all new functions
  • Docstrings have updated with any function changes
  • Internal functions have a preceding underscore (_) and have been added to docs/internal_api/index.rst
  • User functions have been added to docs/user_api/index.rst

Examples

  • Any new notebook examples added to docs/examples/ folder
  • Clear the output of all cells before committing
  • New notebook files added to docs/examples.rst toctree
  • New notebook files added to new entry in docs/gallery.yml with appropriate thumbnail photo in docs/_static/thumbnails/

Copy link
Member

@philipc2 philipc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing this

@philipc2 philipc2 added the bug Something isn't working label Jul 10, 2024
@philipc2 philipc2 merged commit 3e4d460 into UXARRAY:main Jul 10, 2024
17 checks passed
@kjnam
Copy link
Contributor Author

kjnam commented Jul 10, 2024

Thanks for the quick response and for your work. We use a custom UGRID topology name, and this feature is essential.

kjnam added a commit to kjnam/uxarray that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to rename edge_coordinates and face_coordinates names due to missing attrs
2 participants