Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to rename edge_coordinates and face_coordinates names due to missing attrs #846

Closed
kjnam opened this issue Jul 10, 2024 · 0 comments · Fixed by #847
Closed

Fails to rename edge_coordinates and face_coordinates names due to missing attrs #846

kjnam opened this issue Jul 10, 2024 · 0 comments · Fixed by #847
Labels
bug Something isn't working

Comments

@kjnam
Copy link
Contributor

kjnam commented Jul 10, 2024

Version

v2024.06.0

How did you install UXarray?

Conda

What happened?

When a UGRID file uses a custom grid_topology name, the code in _read_ugrid does not rename edge_coordinates and face_coordinates.
There are two bugs:

if "edge_coordinates" in ds["grid_topology"]:
and
if "face_coordinates" in ds["grid_topology"]:
are missing attrs.
face_lon_name, face_lat_name = ds["grid_topology"].edge_coordinates.split()
has a typo.

What did you expect to happen?

Expect to rename custom topology names to edge_lat, edge_lon, face_lat, and face_lon.

Can you provide a MCVE to repoduce the bug?

No response

@kjnam kjnam added the bug Something isn't working label Jul 10, 2024
kjnam added a commit to kjnam/uxarray that referenced this issue Jul 10, 2024
@kjnam kjnam mentioned this issue Jul 10, 2024
14 tasks
@philipc2 philipc2 linked a pull request Jul 10, 2024 that will close this issue
14 tasks
philipc2 pushed a commit that referenced this issue Jul 10, 2024
kjnam added a commit to kjnam/uxarray that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant