Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tetra Star-ID algorithm #91

Open
wants to merge 106 commits into
base: master
Choose a base branch
from
Open

Tetra Star-ID algorithm #91

wants to merge 106 commits into from

Conversation

zeddie888
Copy link
Collaborator

No description provided.

zeddie888 and others added 30 commits August 15, 2022 15:19
@zeddie888
Save
52fd2c5
@zeddie888
Cleanup starter tetra code
652c607
@zeddie888
Implement Pattern construction
2d306b8
@zeddie888
Stop before database work
3259203
@zeddie888
Finish bad Tetra database reading code
3d350d8
@zeddie888
Continue with hashing code
2ad07f9
@zeddie888
Finish bad database generation code, fix seg fault- allocate catalog …
39be1be 
…on heap (vector) instead
@zeddie888
Save progress
e19a515
@zeddie888
Implement argsort- note that must define in .hpp
f388785
@zeddie888
Finish basic star ID working
c5b44a2
@zeddie888
Finish centroid matching, now just return catalog INDEX, not star ID
b9f4528
@zeddie888
Add questionable catalog indexing for LOST attitude step to work
a728d5c
@zeddie888
Update todos
8412944
@zeddie888
Continue documentation
302cae6
@zeddie888
Confirm our previous camera.CameraToSpatial does same thing
5bb9ea9
@zeddie888
Test read from binary, default database
2c18c59
@zeddie888
Bug with generator function
51b625a
@zeddie888
Bring back version of naive database loading
c6fb96b
@zeddie888
Fix false failure bug
1bb5e5d
@zeddie888
Test on database with fov=12, stable sort- success for now
ce775db
@zeddie888
Database generation working as of now!
f624299
@zeddie888
Use pair for range values in binning
bb4ff51
@zeddie888
Fix star ID inclusion issue for db
9b035b9
@zeddie888
Add final star table preprocessing step
77286d0
@zeddie888
Continue Tetra db integration
927bdec
@zeddie888
Save progress on Serialization functions
cb3238a
@zeddie888
Finish first draft of serialize Tetra db
0133514
@zeddie888
Remove outdated TetraDatabase from star-id
d81e120
@zeddie888
Add BuilderTetraDatabase code to io.cpp
c6e6357
@zeddie888
Implement a hacky way to generate Tetra db
00da9fe
markasoftware
markasoftware requested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@markasoftware markasoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, all new command-line options must be documented in man pages

@markasoftware
Copy link
Member

Another comment: No debug info (like "Tetra max angle: XX" or "Found XXX Patterns") should be outputted to std::cout, only to std::cerr, because otherwise if someone tries to use output redirection to save the database (eg ./lost database --tetra > tetra.dat, which should work), it will also save the debug messages and corrupt the database.

@zeddie888 zeddie888 mentioned this pull request May 29, 2023
Open
@zeddie888
Copy link
Collaborator Author

@markasoftware Do you want to take another look at this PR? Newest commits allow Tetra to work nicely with the master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markasoftware markasoftware Awaiting requested review from markasoftware

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zeddie888 @markasoftware