Py open sci review #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - need to confirm it passes docs tests)
fix file structure
Reduce what files it is run on
Doesn't need to be raw string (see Batalex pyOpenSci/software-submission#157 (comment))
* Update domains.py 'Field' -> 'Field***' * 62 r test ci (#86) Update test_r.yaml to install conda outside r, specifically miniforge, then run on env from setup with current package (vs pip installing main)
From issue: pass_filenames: false in the pre-commit config so that the file discovery is done by Ruff taking into account the includes and excludes configured by the user in their pyproject.toml
Try updating to patch version and specify config in args.
try withouth 'docstring-code-format = true' as this may override other settings.
Try to get pre-commit to see config
Warning message, so it is getting these settings from the toml?
E501
E501
Moved constant doc-string to module level
E501
E501
lint/format edits
Without single checking if double is default
…ent. Comment shouldn't cause problems but this one has in the past.
…is used instead of the generic.
…y normalized for doc-test so this may pass.
…nversion() examples
Drop single quote for lint
Revert back to testing on main only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting on pre-commit is passing. 2/3 reviewers have responded that changes/responses to their reviews were to their satisfaction.