Fix tcplPlot bug when compare.val is set and number of plots is greater than 1 #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than 1 Fixes USEPA#280 Add condition to handle `compare.val` with multiple plots in `tcplPlot` function. * **R/tcplPlot.R** - Add a condition to check if `compare.val` is set and the number of plots is greater than 1. - Modify the `if` condition to handle the case when `compare.val` is set and the number of plots is greater than 1. - Ensure that the function does not produce an error when `compare.val` is set and the number of plots is greater than 1. * **tests/testthat/test-plotting.R** - Add a test case to check if `tcplPlot` handles the case when `compare.val` is set and the number of plots is greater than 1. - Ensure that the test case verifies that the function does not produce an error in this scenario. - Add a test case to check if `tcplPlot` handles the case when `compare.val` is set and the number of plots is greater than 1 with `type` set to 'sc'.
|
This does not fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280
Add condition to handle
compare.valwith multiple plots intcplPlotfunction.R/tcplPlot.R
compare.valis set and the number of plots is greater than 1.ifcondition to handle the case whencompare.valis set and the number of plots is greater than 1.compare.valis set and the number of plots is greater than 1.tests/testthat/test-plotting.R
tcplPlothandles the case whencompare.valis set and the number of plots is greater than 1.tcplPlothandles the case whencompare.valis set and the number of plots is greater than 1 withtypeset to 'sc'.